Improve failure message of enum fromOrdinal/valueOf
#19182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
commented
Dec 4, 2023
| @@ -0,0 +1,4 @@ | |||
| Failure(java.util.NoSuchElementException: enum Foo has no case with ordinal: 3) | |||
| Failure(java.lang.IllegalArgumentException: enum Foo has no case with name: Bar) | |||
There was a problem hiding this comment.
@bishabosha why do those methods throw different exceptions? It seems that both could throw a NoSuchElementException.
There was a problem hiding this comment.
Probably compatibility with Java - it throws IllegalArgumentException for valueOf
bishabosha
approved these changes
Dec 15, 2023
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Dec 18, 2023
Follow up of scala#19182. Using `fullName` causes the the `parallelBackend` tests to loop forever. Fixes scala#19285 Fixes scala#19281 Fixes scala#19278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19178